Release binaries after creating writable copy

This commit is contained in:
Carlos Martín Nieto
2013-06-04 23:37:03 +02:00
parent 369a2e5151
commit 9f500e3fa0
3 changed files with 11 additions and 8 deletions

View File

@@ -61,6 +61,7 @@ geef_reference_lookup(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
error = git_reference_lookup(&ref, repo->repo, (char *)bin.data);
enif_release_binary(&bin);
if (error < 0)
return geef_error(env);
@@ -140,6 +141,7 @@ geef_reference_glob(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
error = git_reference_foreach_glob(repo->repo, (char *) bin.data, append_to_list, &data);
enif_release_binary(&bin);
if (error < 0)
return geef_error(env);
@@ -270,12 +272,9 @@ geef_reference_create(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
if (!enif_inspect_iolist_as_binary(env, argv[3], &target))
return enif_make_badarg(env);
/* Allocate the extra byte for the NUL terminator */
if (!enif_realloc_binary(&name, name.size + 1))
if (!geef_terminate_binary(&name))
return geef_oom(env);
name.data[name.size-1] = '\0';
ref = enif_alloc_resource(geef_ref_type, sizeof(geef_ref));
force = enif_is_identical(argv[4], atoms.true);
@@ -285,17 +284,20 @@ geef_reference_create(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
const git_oid *oid = (const git_oid *) target.data;
error = git_reference_create(&ref->ref, repo->repo, pname, oid, force);
} else if (enif_is_identical(argv[2], atoms.symbolic)) {
/* Allocate the extra byte for the NUL terminator */
if (!enif_realloc_binary(&target, target.size + 1))
if (!geef_terminate_binary(&target))
return geef_oom(env);
target.data[target.size - 1] = '\0';
ptarget = (const char *) target.data;
error = git_reference_symbolic_create(&ref->ref, repo->repo, pname, ptarget, force);
enif_release_binary(&target);
} else {
enif_release_binary(&target);
enif_release_binary(&name);
return enif_make_badarg(env);
}
enif_release_binary(&name);
if (error < 0)
return geef_error(env);