forks/geef
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prefer binary realloc to self-managed buffers

Browse Source 
Use erlang's allocator and simplify the code by writing into the
buffer we're going to give back anyway.

Also introduce a function to NUL-terminate iolist buffers, which can
avoid memory copying.
This commit is contained in:
Carlos Martín Nieto
2013-05-02 13:09:51 +02:00
parent ef7d2d5490
commit 616a358dc7
6 changed files with 33 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
c_src/tree.c
View File

@@ -40,7 +40,6 @@ static ERL_NIF_TERM tree_entry_to_term(ErlNifEnv *env, const git_tree_entry *ent
ERL_NIF_TERM
geef_tree_bypath(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
{
char *path;
int error;
geef_object *obj;
ErlNifBinary bin;
@@ -52,17 +51,10 @@ geef_tree_bypath(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[])
if (!enif_inspect_iolist_as_binary(env, argv[1], &bin))
return enif_make_badarg(env);
path = malloc(bin.size + 1);
if (!path)
if (!geef_terminate_binary(&bin))
return geef_oom(env);
memcpy(path, bin.data, bin.size);
path[bin.size] = '\0';
error = git_tree_entry_bypath(&entry, (git_tree *)obj->obj, path);
free(path);
if (error < 0)
if (git_tree_entry_bypath(&entry, (git_tree *)obj->obj, (char *) bin.data) < 0)
return geef_error(env);
return tree_entry_to_term(env, entry);