From 6d9819c7c147b2088cf4337027e68f9048cd11f3 Mon Sep 17 00:00:00 2001
From: Alexey Romanov <alexey.v.romanov@gmail.com>
Date: Fri, 19 Nov 2010 16:59:25 +0300
Subject: [PATCH] Improved large numbers test

---
 c_src/sqlite3_drv.c   |  9 ++++++---
 test/sqlite3_test.erl | 19 ++++++++++++-------
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/c_src/sqlite3_drv.c b/c_src/sqlite3_drv.c
index 733c051..42309ce 100644
--- a/c_src/sqlite3_drv.c
+++ b/c_src/sqlite3_drv.c
@@ -191,11 +191,14 @@ static inline int decode_and_bind_param(
   double double_val;
   char* char_buf_val;
   switch (*type) {
+//  case ERL_SMALL_INTEGER_EXT:
+//    ei_decode_long(buffer, index, &long_val);
+//    result = sqlite3_bind_int(statement, param_index, long_val);
+//    break;
   case ERL_SMALL_INTEGER_EXT:
-    ei_decode_long(buffer, index, &long_val);
-    result = sqlite3_bind_int(statement, param_index, long_val);
-    break;
   case ERL_INTEGER_EXT:
+  case ERL_SMALL_BIG_EXT:
+  case ERL_LARGE_BIG_EXT:
     ei_decode_longlong(buffer, index, &int64_val);
     result = sqlite3_bind_int64(statement, param_index, int64_val);
     break;
diff --git a/test/sqlite3_test.erl b/test/sqlite3_test.erl
index 85e7cc0..4efa9cb 100644
--- a/test/sqlite3_test.erl
+++ b/test/sqlite3_test.erl
@@ -30,8 +30,10 @@ drop_table_if_exists(Db, Table) ->
     end.
 
 rows(SqlExecReply) ->
-    [{columns, _Columns}, {rows, Rows}] = SqlExecReply,
-    Rows.
+    case SqlExecReply of
+        [{columns, _Columns}, {rows, Rows}] -> Rows;
+        {error, Reason} -> {error, Reason}
+    end.
 
 all_test_() ->
     {setup,
@@ -109,10 +111,10 @@ parametrized() ->
     sqlite3:sql_exec(ct, "INSERT INTO user1 (id, name) VALUES (?, ?)", [{1, 1}, {2, "john"}]),
     sqlite3:sql_exec(ct, "INSERT INTO user1 (id, name) VALUES (?3, ?5)", [{3, 2}, {5, "joe"}]),
     sqlite3:sql_exec(ct, "INSERT INTO user1 (id, name) VALUES (:id, @name)", [{":id", 3}, {'@name', <<"jack">>}]),
-    sqlite3:sql_exec(ct, "INSERT INTO user1 (id, name) VALUES (?, ?)", [4, "james"]),
+    sqlite3:sql_exec(ct, "INSERT INTO user1 (id, name) VALUES (?, ?)", [4294967295, "james"]),
     ?assertEqual(
         [{columns, ["id", "name"]}, 
-         {rows, [{1, <<"john">>}, {2, <<"joe">>}, {3, <<"jack">>}, {4, <<"james">>}]}], 
+         {rows, [{1, <<"john">>}, {2, <<"joe">>}, {3, <<"jack">>}, {4294967295, <<"james">>}]}], 
         sqlite3:read_all(ct, user1)),
     sqlite3:drop_table(ct, user1),
     sqlite3:create_table(ct, user1, [{i, integer}, {d, double}, {b, blob}]),
@@ -188,10 +190,13 @@ nonexistent_table_info() ->
     ?assertEqual(table_does_not_exist, sqlite3:table_info(ct, nonexistent)).
 
 large_number() ->
-    N1 = 4294967295,
-    N2 = (N1 + 1) div 2,
+    N1 = 9223372036854775807,
+    N2 = -9223372036854775808,
     Query1 = io_lib:format("select ~p, ~p", [N1, N2]),
-    ?assertEqual([{N1, N2}], rows(sqlite3:sql_exec(ct, Query1))).
+    ?assertEqual([{N1, N2}], rows(sqlite3:sql_exec(ct, Query1))),
+    Query2 = "select ?, ?",
+    ?assertEqual([{N1, N2}], rows(sqlite3:sql_exec(ct, Query2, [N1, N2]))),
+    ?assertNot([{N1 + 1, N2 - 1}] == rows(sqlite3:sql_exec(ct, Query2, [N1 + 1, N2 - 1]))).
 
 % create, read, update, delete
 %%====================================================================